Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to nix flakes #1508

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

switch to nix flakes #1508

wants to merge 12 commits into from

Conversation

wd15
Copy link
Collaborator

@wd15 wd15 commented Jul 7, 2023 •
edited
Loading

Update PFHub to use Nix Flakes rather than the old shell.nix protocol. Flakes are essentially far more composable than the shell.nix way.

Changes:

  • Single flake.nix environment for running everything. No more separate environments. There is a flake.nix in _data/python-pfhub for development of the Python package, but the flake.nix in the base directory references that.
  • All *.nix files are now gone and replaced with only twp flake.nix files
  • No longer using htmlproofer as building it with Ruby was presented too many problems. Not so concerned about this, but we're no longer testing links.
  • Stopped using Travis CI. Functionality moved to .github/workflows/test-jekyll.yml.
  • Updated Docker to use flakes
  • Removed _apps as the apps are no longer used
  • Cleaned up code in _data/python-pfhub to account for new versions of the linters
  • new docker image on docker.io
  • update documentation for nix and docker changes
  • nix generates the docker image now

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@pfhub
Copy link
Collaborator

pfhub commented Jul 7, 2023

@wd15, the new version of the PFHub website is available at https://random-cat-1508.surge.sh

11 similar comments
@pfhub
Copy link
Collaborator

pfhub commented Jul 7, 2023

@wd15, the new version of the PFHub website is available at https://random-cat-1508.surge.sh

@pfhub
Copy link
Collaborator

pfhub commented Jul 7, 2023

@wd15, the new version of the PFHub website is available at https://random-cat-1508.surge.sh

@pfhub
Copy link
Collaborator

pfhub commented Jul 7, 2023

@wd15, the new version of the PFHub website is available at https://random-cat-1508.surge.sh

@pfhub
Copy link
Collaborator

pfhub commented Jul 7, 2023

@wd15, the new version of the PFHub website is available at https://random-cat-1508.surge.sh

@pfhub
Copy link
Collaborator

pfhub commented Jul 10, 2023

@wd15, the new version of the PFHub website is available at https://random-cat-1508.surge.sh

@pfhub
Copy link
Collaborator

pfhub commented Jul 10, 2023

@wd15, the new version of the PFHub website is available at https://random-cat-1508.surge.sh

@pfhub
Copy link
Collaborator

pfhub commented Jul 17, 2023

@wd15, the new version of the PFHub website is available at https://random-cat-1508.surge.sh

@pfhub
Copy link
Collaborator

pfhub commented Jul 17, 2023

@wd15, the new version of the PFHub website is available at https://random-cat-1508.surge.sh

@pfhub
Copy link
Collaborator

pfhub commented Jul 18, 2023

@wd15, the new version of the PFHub website is available at https://random-cat-1508.surge.sh

@pfhub
Copy link
Collaborator

pfhub commented Jul 18, 2023

@wd15, the new version of the PFHub website is available at https://random-cat-1508.surge.sh

@pfhub
Copy link
Collaborator

pfhub commented Jul 18, 2023

@wd15, the new version of the PFHub website is available at https://random-cat-1508.surge.sh

@wd15 wd15 changed the title Update python-pfhub to use nix flakes switch to nix flakes Aug 4, 2023
@wd15 wd15 requested review from tkphd and guyer August 4, 2023 16:28
@wd15 wd15 added this to the October 2023 Meeting milestone Aug 4, 2023
@guyer
Copy link
Member

guyer commented Aug 4, 2023

.github/workflows/test-jekyll.yml?

@wd15 wd15 marked this pull request as ready for review August 4, 2023 20:02
@wd15 wd15 mentioned this pull request Aug 7, 2023
Draft
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkphd tkphd Awaiting requested review from tkphd

@guyer guyer Awaiting requested review from guyer

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
August 2023 Meeting
Development

Successfully merging this pull request may close these issues.
3 participants
@wd15 @pfhub @guyer